First PR #1
First PR #1
Conversation
|
|
.idea/compiler.xml
Outdated
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
entry/src/main/config.json
Outdated
| @@ -0,0 +1,59 @@ | |||
| { | |||
| "app": { | |||
| "bundleName": "com.example.smart_wash_library", | |||
There was a problem hiding this comment.
provide better bundle name like for example, com.ohos.lib.smart.wash
| { | ||
| "app": { | ||
| "bundleName": "com.example.smart_wash_library", | ||
| "vendor": "example", |
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "strings": { | |||
| left: 22px; | ||
| } | ||
| .tlabel3{ | ||
| color: white; font-weight: 800; font-size: 20.3px; |
There was a problem hiding this comment.
format code in all files and remove unnecessary blank lines
| margin-left: 136.58px; | ||
| border:2px solid blue; | ||
| } | ||
| /*.slider {*/ |
There was a problem hiding this comment.
remove commented code in all places
| @@ -0,0 +1,98 @@ | |||
| <element src="../../../../../../../smartwash/js/index.hml" name="test"></element> | |||
There was a problem hiding this comment.
provide proper name instead of test
| @@ -0,0 +1,8 @@ | |||
| export default { | |||
| data: { | |||
| title: "" | |||
| </div> | ||
|
|
||
| <div class="menut"> | ||
| <text class="time">10:00 PM</text> |
There was a problem hiding this comment.
dont hardcode date... get the correct date from sdk's api and display.
| <div class="full"> | ||
| <div class="timer"> | ||
| <image class="level_bg" src="/common/images/level_bg.png"></image> | ||
| <image class="Timmer_bg" src="/common/images/Timer_bg.png"></image> |
There was a problem hiding this comment.
Include the functionality like for example for wash type, user clicks on spin shall update UI accordingly.
| <progress class="min-progress" type="ring" percent= "40" ></progress> | ||
| <image class="indication_point" src="/common/images/indication_point.png"></image> | ||
|
|
||
| <image src="/common/images/fill.png"class="fill"></image> |
There was a problem hiding this comment.
All such options displayed in UI, please maintain as array in js and use that to display in hml, instead of directly hardcoding over here
|
|
||
| </div> | ||
|
|
||
| <div class="waterlevel"> |
There was a problem hiding this comment.
Also maintain setter functions in js file to update data whenever user click happens like for example water level is changed, then setWaterLevel function should take care of updating data.
Also water level data displayed in UI should be defined in js and looped here to display
No description provided.